[webkit-reviews] review requested: [Bug 33977] WebNode::toElement refcounts incorrectly : [Attachment 47155] Fixes the bug by using WebNode::assign()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 21 16:07:57 PST 2010
James Robinson <jamesr at chromium.org> has asked for review:
Bug 33977: WebNode::toElement refcounts incorrectly
https://bugs.webkit.org/show_bug.cgi?id=33977
Attachment 47155: Fixes the bug by using WebNode::assign()
https://bugs.webkit.org/attachment.cgi?id=47155&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
I have to use the WebNode:: qualifier because some T's that are used in this
function (like WebElement) define incompatible 1-arg versions of ::assign(),
for example WebElement::assign(const WebElement& e). This confuses visual
studio terribly. I'm not sure if this is an issue with the compiler, but we
always want to use the WebNode::assign() version anyway.
More information about the webkit-reviews
mailing list