[webkit-reviews] review requested: [Bug 32953] [Qt] Qt DRT: respect window.close() and window.closed() : [Attachment 47148] Patch to fix crashes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 21 14:50:20 PST 2010


Robert Hogan <robert at roberthogan.net> has asked  for review:
Bug 32953: [Qt] Qt DRT: respect window.close() and window.closed()
https://bugs.webkit.org/show_bug.cgi?id=32953

Attachment 47148: Patch to fix crashes
https://bugs.webkit.org/attachment.cgi?id=47148&action=review

------- Additional Comments from Robert Hogan <robert at roberthogan.net>
Very sorry about that - I can only recreate one of the crashes locally (the
first) and have fixed it with the attached. The second still has the debug
output on the buildbot and I can see it crashed for the same reason, so this
should fix both. It's not entirely clear to me why m_topLoadingFrame is null
when loadFinished fires so the fix is just a workaround.

Also - patch has no changelog since original one is still there - assume that's
OK?


More information about the webkit-reviews mailing list