[webkit-reviews] review denied: [Bug 33971] Check base URI validity before using in SVGImageLoader::sourceURI : [Attachment 47145] patch checks for URL validity before using

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Bryan Yeung <bryeung at chromium.org>'s
request for review:
Bug 33971: Check base URI validity before using in SVGImageLoader::sourceURI
https://bugs.webkit.org/show_bug.cgi?id=33971

Attachment 47145: patch checks for URL validity before using
https://bugs.webkit.org/attachment.cgi?id=47145&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The call to deprecatedParseURL needs to be on the attr value *before* invoking
KURL at all. Making that change alone might fix the bug. Something like this:

    return KURL(element()->baseURI(), deprecatedParseURL(attr));

This bug needs a test case. review- for lack of a test case and because the fix
is probably wrong.