[webkit-reviews] review requested: [Bug 32722] Allow Reserved Words in Property Accessors : [Attachment 47127] 2010-01-21-a patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 21 09:24:13 PST 2010


Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 32722: Allow Reserved Words in Property Accessors
https://bugs.webkit.org/show_bug.cgi?id=32722

Attachment 47127: 2010-01-21-a patch
https://bugs.webkit.org/attachment.cgi?id=47127&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
attempt at a final patch:

- seems like a general 1% increase in parse time across the board

- reverrted back to "patch so far" styled change for the property rules -
causes an additional reduce step by the compiler but doesn't require the code
duplication for having the duplicate IDENT/IdentifierOrReserved rules

- sorted the token lists in the %token specs and IdentifierOrReserved
definition.

- added LayoutTests/fast/js/reserved-words-as-properties-expected.txt to test
using all keywords/reserved words as properties


More information about the webkit-reviews mailing list