[webkit-reviews] review requested: [Bug 33915] Web Inspector: JavaScript Error in DOMAgent.js:375 (_attributesUpdated) : [Attachment 47117] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 21 06:53:24 PST 2010


Kelly Norton <knorton at google.com> has asked  for review:
Bug 33915: Web Inspector: JavaScript Error in DOMAgent.js:375
(_attributesUpdated)
https://bugs.webkit.org/show_bug.cgi?id=33915

Attachment 47117: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=47117&action=review

------- Additional Comments from Kelly Norton <knorton at google.com>
The problem is due to the special treatment of the styleAttr. When
InspectorDOMAgent calls Element::attributes to build a list of attributes, it
ends up calling setAttribute for the styleAttr. This shows up in the
InspectorDOMAgent as a spurious Attr modification. The fix is to ignore all
attr modifications when m_synchronizingStyleAttribute is set.


More information about the webkit-reviews mailing list