[webkit-reviews] review granted: [Bug 33589] [Android] Bridge interfaces Field, Class, Instance and Array use JSC-specific types : [Attachment 47023] Patch 4 for Bug 33589

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 33589: [Android] Bridge interfaces Field, Class, Instance and Array use
JSC-specific types
https://bugs.webkit.org/show_bug.cgi?id=33589

Attachment 47023: Patch 4 for Bug 33589
https://bugs.webkit.org/attachment.cgi?id=47023&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/bridge/Bridge.h
> - * Copyright (C) 2003, 2008, 2009 Apple Inc. All rights reserved.
> + * Copyright (C) 2003, 2008, 2009, 2010 Apple Inc. All rights reserved.

It seems odd to add 2010 to the Apple copyright. I think you should add your
own.

> +#if USE(JSC)
> +#include "BridgeJSC.h"
> +#endif

It seems that the preferred pattern is to put the if in the header itself and
just include it unconditionally.