[webkit-reviews] review granted: [Bug 16318] Insufficient repaint issues with html embedded in foreignObject : [Attachment 47096] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Oliver Hunt <oliver at apple.com>'s request for
review:
Bug 16318: Insufficient repaint issues with html embedded in foreignObject
https://bugs.webkit.org/show_bug.cgi?id=16318

Attachment 47096: Patch
https://bugs.webkit.org/attachment.cgi?id=47096&action=review

------- Additional Comments from mitz at webkit.org
> +IntRect RenderListMarker::localSelectionRect()
> +{
> +    InlineBox* box = inlineBoxWrapper();
> +    if (!box)
> +	   return IntRect();
> +    RootInlineBox* root = box->root();
> +    if (!root)
> +	   return IntRect();

No need to null-check root.

> +    IntRect localSelectionRect();

You should use this new function in selectionRectForRepaint() too instead of
having duplicated code.

r=me but please do ^ if possible.