[webkit-reviews] review granted: [Bug 28622] Caught exceptions still pause the debugger : [Attachment 47083] [PATCH] Tri-State Button + Tim's Comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 20 17:19:32 PST 2010


Timothy Hatcher <timothy at hatcher.name> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 28622: Caught exceptions still pause the debugger
https://bugs.webkit.org/show_bug.cgi?id=28622

Attachment 47083: [PATCH] Tri-State Button + Tim's Comments
https://bugs.webkit.org/attachment.cgi?id=47083&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
>      get toggled()
>      set toggled(x)

You should renamed these too. But that will touch more files. Maybe add a
get/set state, and make toggled use that only for states == 2? And throw
otherwise.


More information about the webkit-reviews mailing list