[webkit-reviews] review granted: [Bug 33911] HTMLInputElement::valueAsDate setter support for type=date. : [Attachment 47046] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 33911: HTMLInputElement::valueAsDate setter support for type=date.
https://bugs.webkit.org/show_bug.cgi?id=33911

Attachment 47046: Patch
https://bugs.webkit.org/attachment.cgi?id=47046&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (beforeGregorianStartDate(m_year, m_month, m_monthDay))
> +	   return false;

It seems bad that in this case the function returns false, but has already had
a side effect and changed the state of the ISODateTime object. Ideally
functions would either succeed or leave the object untouched. In this patch
there seems no problem with the behavior, but it is surprising to me.