[webkit-reviews] review requested: [Bug 33842] [Qt] media tests crash : [Attachment 47047] patch

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 33842: [Qt] media tests crash
https://bugs.webkit.org/show_bug.cgi?id=33842

Attachment 47047: patch
https://bugs.webkit.org/attachment.cgi?id=47047&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
OK, these two stack traces are definitely worth investigating but it seems that
they are more or less unrelated.

What is strange in these traces is that the application gets destroyed. It
turns out that in fact these tests are not crashing (except these two random
cases). They are passing but the DRT quits after they end. The run-webkit-tests
gets confused and clasifies that as a crash.

The question is why DRT quits: it looks related to
http://trac.webkit.org/changeset/38223.

The video widget has no parent and therefore is considered to be a top window.
Thus, its lifetime has influence on the application's lifetime (see
http://qt.nokia.com/doc/4.6/qapplication.html#lastWindowClosed). However, I
still don't get why the deletion of the video widget triggers the application
quit. There is still the main QWebView, which should keep it running.

I wonder why the above change was limited to Qt < 4.5 only? In case it is safe
to make that change version-independent, I'm attaching a patch.