[webkit-reviews] review granted: [Bug 33908] [Chromium] Skia "seatbelts" should be removed. : [Attachment 47042] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 20 09:54:45 PST 2010


David Levin <levin at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 33908: [Chromium] Skia "seatbelts" should be removed.
https://bugs.webkit.org/show_bug.cgi?id=33908

Attachment 47042: Patch
https://bugs.webkit.org/attachment.cgi?id=47042&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Disable the "seatbelt" coordinate validation functions in the
> +	   Skia graphics layer.  We believe all the underlying bugs have
> +	   been fixed, but just in case we're being overly optimistic, this
> +	   leaves in the code for an easy revert.

Please add a bug link here.


> Index: WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
> +// Diabling these checks (20/01/2010), since we think we've fixed all the
Skia

typo: Diabling


More information about the webkit-reviews mailing list