[webkit-reviews] review granted: [Bug 33153] [multi-patch]Running multiple instances of run-webkit-tests is not possible on the same machine : [Attachment 47012] Updated patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Andras Becsi
<abecsi at inf.u-szeged.hu>'s request for review:
Bug 33153: [multi-patch]Running multiple instances of run-webkit-tests is not
possible on the same machine
https://bugs.webkit.org/show_bug.cgi?id=33153

Attachment 47012: Updated patch
https://bugs.webkit.org/attachment.cgi?id=47012&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> closeHTTPD() returns 0 if the closing of Apache succeeded it returns 1 if for

> some reason the termination timed out.

Indeed - I was looking at an old version of this function when I made this
comment.

It's unfortunate to have a function that returns 0 on success, and 1 on
failure. Please consider changing this - even having to negate the result each
time seems like a low price for consistent return values.

+sub waitForUserInterrupt
+{
+    $standalone = 1;
+}

This function doesn't wait, it only sets a bit - so it should be called e.g.
"setShouldWaitForUserInterrupt". Also, $standalone should be renamed, too.

r=me, but at least the latter naming issue should be fixed before landing. You
may want to submit an updated patch for commit-queue, or someone can make the
changes locally, and land this one.