[webkit-reviews] review denied: [Bug 33903] FTBFS on GNU/kFreeBSD caused by missing strnstr() on glibc systems : [Attachment 47028] fix kfreebsd ftbfs

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Fathi Boudra <fabo at debian.org>'s
request for review:
Bug 33903: FTBFS on GNU/kFreeBSD caused by missing strnstr() on glibc systems
https://bugs.webkit.org/show_bug.cgi?id=33903

Attachment 47028: fix kfreebsd ftbfs
https://bugs.webkit.org/attachment.cgi?id=47028&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Platforms that happen to have glibc are not OS(LINUX) and just because that's
handy at one particular call site does not mean this is the correct way to do
it.

The right way to do this is to change the check at the strnstr definition,
perhaps as described in the FIXME in StringExtras.h.

Maciej Stachowiak is working on rationalizing Platform.h and might have a
suggestion on the correct way to handle this.