[webkit-reviews] review granted: [Bug 33900] [Gtk] media/video-play-pause-exception.html is flacky : [Attachment 47024] Refactored the test to use the pause event instead of a timer.

Wed Jan 20 08:29:44 PST 2010

Darin Adler <darin at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 33900: [Gtk] media/video-play-pause-exception.html is flacky
https://bugs.webkit.org/show_bug.cgi?id=33900

Attachment 47024: Refactored the test to use the pause event instead of a
timer.
https://bugs.webkit.org/attachment.cgi?id=47024&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +<html>
> +<body>

This seems like a pointless change to me; including explicit HTML and body
elements does not make our tests better. I assume it has no effect on the test.

> +    waitForEvent("pause", onpause);

It seems to me we should call waitForEvent("pause") before calling video.play()
and video.pause().

I would not have preserved the blank line at the end of the test created with
consoleWrite.

I would probably have used waitForEventTestAndEnd.

Seems OK as is. r=me