[webkit-reviews] review denied: [Bug 33902] Opcode.h use const void* for Opcode cause error #1211 for RVCT compiler : [Attachment 47035] Patch for bug 33902

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 20 08:14:11 PST 2010


Darin Adler <darin at apple.com> has denied Lyon Chen
<lyon.chen at torchmobile.com>'s request for review:
Bug 33902: Opcode.h use const void* for Opcode cause error #1211 for RVCT
compiler
https://bugs.webkit.org/show_bug.cgi?id=33902

Attachment 47035: Patch for bug 33902
https://bugs.webkit.org/attachment.cgi?id=47035&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Two problems here:

    1) We don't accept patches without change log entries.

    2) This is probably not something that should be ifdef'd based on compiler.
If void* works for the other compilers, then the patch should just switch from
const void* to void*.


More information about the webkit-reviews mailing list