[webkit-reviews] review denied: [Bug 33857] [Qt] Need a public API for suspending/resuming DOM Objects on a page : [Attachment 46942] Add an option to QtLauncher to be easy to suspend/resume DOM Objects on the current page

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Jesus
Sanchez-Palencia <jesus.palencia at openbossa.org>'s request for review:
Bug 33857: [Qt] Need a public API for suspending/resuming DOM Objects on a page
https://bugs.webkit.org/show_bug.cgi?id=33857

Attachment 46942: Add an option to QtLauncher to be easy to suspend/resume DOM
Objects on the current page
https://bugs.webkit.org/attachment.cgi?id=46942&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
> From debee88b204b8faf48edca5bca37b6b25e5a26cc Mon Sep 17 00:00:00 2001
> From: Jesus Sanchez-Palencia <jesferna at darjeeling.(none)>
> Date: Tue, 19 Jan 2010 17:17:45 -0300
> Subject: [PATCH 2/2] Add suspend/resume page option to QtLauncher
> 
> Reviewed by NOBODY (OOPS!).
> 
> [QT] Need a public API for suspending/resuming DOM Objects on a page
> https://bugs.webkit.org/show_bug.cgi?id=33857

It is called Qt


> +	   suspendDOMObjects = false;

Doesn't the launcher uses m_ for member fields?

> +	       QWebPage* page = view->page();
> +	       page->suspend();

Why not call it directly?

> +    void toggleSuspendResumeObjects(bool on)

That doesnt seem much like a toggle if it takes a bool argument.