[webkit-reviews] review granted: [Bug 33775] check-webkit-style: File reading code should be shared between cpp_style.py and text_style.py. : [Attachment 46985] Proposed patch 4

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 33775: check-webkit-style: File reading code should be shared between
cpp_style.py and text_style.py.
https://bugs.webkit.org/show_bug.cgi?id=33775

Attachment 46985: Proposed patch 4
https://bugs.webkit.org/attachment.cgi?id=46985&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for addressing my comments! Looks good.

> I prefer keeping them separate since the file type depends only on the path
and
> extension, and separating the two makes this fact clearer.  I changed the
> strings to an enum-like idiom to avoid use of strings -- if that helps. 
Also,
> in the future we may want to separate this class into two classes
> (ProcessorFactory and FileTypeResolver).

Thanks for creating the enum values. I think using them is better than the
string-literal approach.