[webkit-reviews] review denied: [Bug 33880] [Chromium] Need a way of getting a WebApplicationCacheHost ptr out of the WebKitAPI. : [Attachment 46976] fix style errors

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 33880: [Chromium] Need a way of getting a WebApplicationCacheHost ptr out
of the WebKitAPI.
https://bugs.webkit.org/show_bug.cgi?id=33880

Attachment 46976: fix style errors
https://bugs.webkit.org/attachment.cgi?id=46976&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebApplicationCacheHost.h
...
> +#if WEBKIT_IMPLEMENTATION
> +    static WebApplicationCacheHost*
fromApplicationCacheHost(WebCore::ApplicationCacheHost*);
> +#endif

hmm... how about creating src/ApplicationCacheHostInternal.h, and then
just expose toWebApplicationCacheHost from there?  That way we won't
need any implementation details added to the public header (albeit
in a WEBKIT_IMPLEMENTATION section).

otherwise, this lgtm.