[webkit-reviews] review denied: [Bug 33496] webkit-commit-queue status page is confusing : [Attachment 46964] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 20:02:22 PST 2010


Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 33496: webkit-commit-queue status page is confusing
https://bugs.webkit.org/show_bug.cgi?id=33496

Attachment 46964: Patch
https://bugs.webkit.org/attachment.cgi?id=46964&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
	 if is_svn_apply:
-	     QueueEngine.exit_after_handled_error(script_error)
+	     return # No need to update the bug for svn-apply failures.
[...]
-	 exit(1)

How is the master process supposed to distinguish these cases if we don't
return a different exit code?


More information about the webkit-reviews mailing list