[webkit-reviews] review denied: [Bug 28622] Caught exceptions still pause the debugger : [Attachment 46967] [PATCH] Add a hasHandler parameter to JavaScriptDebugServer::exception
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 19 18:56:37 PST 2010
Geoffrey Garen <ggaren at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 28622: Caught exceptions still pause the debugger
https://bugs.webkit.org/show_bug.cgi?id=28622
Attachment 46967: [PATCH] Add a hasHandler parameter to
JavaScriptDebugServer::exception
https://bugs.webkit.org/attachment.cgi?id=46967&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think you need to "UNUSED_PARAM(hasHandler);" in WebScriptDebugger too. The
rest of the code looks correct, though.
FWIW, I agree with Oliver about this feature: DashCode's behavior is odd. Maybe
we could add a tri-state button. But have any real users requested one?
More information about the webkit-reviews
mailing list