[webkit-reviews] review denied: [Bug 32189] [GTK] Integrate running of API tests into buildbot run : [Attachment 44353] proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 32189: [GTK] Integrate running of API tests into buildbot run
https://bugs.webkit.org/show_bug.cgi?id=32189

Attachment 44353: proposed patch
https://bugs.webkit.org/attachment.cgi?id=44353&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We have shared code for how to get the configuration directory in
webkitdirs.pm.	I think we should re-use that here.  Meaning we should just
make run-gtk-tests a perl script.  Unfortunately we don't have any equivalent
detection code for python or I would suggest we write this in python instead.
:)

In general the code looks OK.  I'm not really an expert on the internals of
buildbot.  There might be a more concise way to write parts of the class.

No need to call bash directly, or?
+    command = ["bash", "./WebKitTools/Scripts/run-gtk-tests",
WithProperties("--%(configuration)s")]

r- for not re-using existing configuration directory detection logic.