[webkit-reviews] review requested: [Bug 33865] [Chromium] svg/custom/stroke-width-click.svg fixes : [Attachment 46950] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 13:53:26 PST 2010


Garret Kelly <gdk at chromium.org> has asked  for review:
Bug 33865: [Chromium] svg/custom/stroke-width-click.svg fixes
https://bugs.webkit.org/show_bug.cgi?id=33865

Attachment 46950: Initial patch
https://bugs.webkit.org/attachment.cgi?id=46950&action=review

------- Additional Comments from Garret Kelly <gdk at chromium.org>
Two issues:
- The way that stroke-width-click is written causes double-click events within
the Chromium test_shell and triggers an ASSERT that is unrelated to the test.
- The output formatting does not allow for variances between platforms.

I've attached a patch that resolves this issue by reordering the click events
so as to not trigger the double-click logic, and which changes the output
formatting to not have rigid expectations.


More information about the webkit-reviews mailing list