[webkit-reviews] review requested: [Bug 33773] MSAA: The child <option> elements of a non-multiple <select> are not exposed : [Attachment 46947] patch

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has asked	for review:
Bug 33773: MSAA: The child <option> elements of a non-multiple <select> are not
exposed
https://bugs.webkit.org/show_bug.cgi?id=33773

Attachment 46947: patch
https://bugs.webkit.org/attachment.cgi?id=46947&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
This patch adds Alice's suggested changes.

The class AccessibilityMenuListHiddenList was renamed to
AccessibilityMenuListPopup to better reflect which object in the tree it
represents.

The "collapsed", "expanded", and "has popup" states were added to the MSAA
wrapper object.

To test the expanded state of the select menu, we now allow the menu to be
expanded and collapsed via the MSAA wrapper's accDoDefaultAction() call. Code
was added to the layout test to test the popup menu's state and the state of
its child option elements with the menu expanded.