[webkit-reviews] review denied: [Bug 32461] [Qt] Adding QPixmap/QImage support for the Qt hybrid layer : [Attachment 46848] Use /dev/null for new files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 12:36:51 PST 2010


Simon Hausmann <hausmann at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 32461: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
https://bugs.webkit.org/show_bug.cgi?id=32461

Attachment 46848: Use /dev/null for new files
https://bugs.webkit.org/attachment.cgi?id=46848&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
The patch is fine with me, and in fact I can apply it locally with patch -p0. I
was about to review and land it, but unfortunately it is missing ChangeLog
entries.

Noam, can you add those with explanations of your changes? AFAICS that's the
only thing missing we need to land it.

(If the bots have problems, it's okay, we can land it manually)

Sorry :(


More information about the webkit-reviews mailing list