[webkit-reviews] review denied: [Bug 33539] [GTK] handle media redirections : [Attachment 46923] media redirections support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 12:33:17 PST 2010


Oliver Hunt <oliver at apple.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 33539: [GTK] handle media redirections
https://bugs.webkit.org/show_bug.cgi?id=33539

Attachment 46923: media redirections support
https://bugs.webkit.org/attachment.cgi?id=46923&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Ah right, i see what you're doing, you're doing an origin check of the document
versus the media.  That's not what we want to do.  What we want to do is make
any redirect in the media that goes to a different origin from the current
origin be forbidden

Eg. if i have

http://example.com/foo.mov and that media file contains a redirect to
http://example.com/foo2.mov that's okay, if i instead it redirects to
http://evil.com/foo.mov then the media should be blocked.  This has nothing to
do with the containing document.


More information about the webkit-reviews mailing list