[webkit-reviews] review granted: [Bug 33819] Style in WebCore/bridge/jni/jsc/JavaClassJSC needs fixing : [Attachment 46924] Patch 2 for Bug 33819

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 33819: Style in WebCore/bridge/jni/jsc/JavaClassJSC needs fixing
https://bugs.webkit.org/show_bug.cgi?id=33819

Attachment 46924: Patch 2 for Bug 33819
https://bugs.webkit.org/attachment.cgi?id=46924&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> Index: WebCore/bridge/jni/jsc/JavaClassJSC.cpp
> ===================================================================
> --- WebCore/bridge/jni/jsc/JavaClassJSC.cpp	(revision 53450)
> +++ WebCore/bridge/jni/jsc/JavaClassJSC.cpp	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (C) 2003 Apple Computer, Inc.  All rights reserved.
> + * Copyright (C) 2003-2010 Apple Computer, Inc.  All rights reserved.

Folks prefer the years to be listed explicitly. Feel free to do 2003, 2010

> +    return (!strcmp(m_name, "java.lang.Byte")
> +	   || !strcmp(m_name, "java.lang.Short")

Ideally this would line up with the parenthesis that is enclosing it like this:


    return (!strcmp(m_name, "java.lang.Byte")
	    || !strcmp(m_name, "java.lang.Short")


> +	   || !strcmp(m_name, "java.lang.Integer")
> +	   || !strcmp(m_name, "java.lang.Long")
> +	   || !strcmp(m_name, "java.lang.Float")
> +	   || !strcmp(m_name, "java.lang.Double"));

> Index: WebCore/bridge/jni/jsc/JavaClassJSC.h
> - * Copyright (C) 2003 Apple Computer, Inc.  All rights reserved.
> + * Copyright (C) 2003-2005, 2007, 2009, 2010 Apple Computer, Inc.  All
rights reserved.

Same comment about year ranges.