[webkit-reviews] review requested: [Bug 32169] Implement TextCodec for WINCE port : [Attachment 46925] The patch (additonal style issues fixed)

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 32169: Implement TextCodec for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=32169

Attachment 46925: The patch (additonal style issues fixed)
https://bugs.webkit.org/attachment.cgi?id=46925&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #5)
> Why isn't this method declared in a header?  Is it defined in
> WebCore/platform/graphics/wince/FontCacheWince.cpp.  If it's a utility
method,
> I think it should be moved to its own header and source file.
Where is the best place for this method? Isn't it better to add it as static
function in TextCodec or FontCache?

> Why is receive() a pure virtual function?  It's implementation doesn't seem
> optional in enumerateSupportedEncodings().
What is wrong with an abstract class at this place?