[webkit-reviews] review canceled: [Bug 32565] [Qt] Initialization of a new API; QtScript. : [Attachment 46913] Initialization of API v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 10:17:11 PST 2010


Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has canceled Jędrzej Nowacki
<jedrzej.nowacki at nokia.com>'s request for review:
Bug 32565: [Qt] Initialization of a new API; QtScript.
https://bugs.webkit.org/show_bug.cgi?id=32565

Attachment 46913:  Initialization of API v3
https://bugs.webkit.org/attachment.cgi?id=46913&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
Kent have found some issues with the code:
- use of C cast
- toString() method should return "true", "false", "null", "undefined" instead
of "True", "False", "null", "undefined"
- one spelling mistake

I will create another version of the patch... If there are other issues please
feel free to comment :-)


More information about the webkit-reviews mailing list