[webkit-reviews] review granted: [Bug 33828] Crash in Page::backForwardList when using History object from a detached window : [Attachment 46922] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 33828: Crash in Page::backForwardList when using History object from a
detached window
https://bugs.webkit.org/show_bug.cgi?id=33828

Attachment 46922: Patch
https://bugs.webkit.org/attachment.cgi?id=46922&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
"The spec really cover expected behavior"?

The test should not just have empty output - a link to the bug and a phrase
like "Passed in didn't crash" would suffice.

Please add try/catch around each subtest - we want to test pushState even if
replaceState raises an exception.

r=me if you fix the above nitpicks.