[webkit-reviews] review granted: [Bug 33803] Web Inspector: PanelEnablerView._windowResized is slow, called even when the view is hidden : [Attachment 46906] patch (comments followed)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 08:48:45 PST 2010


Timothy Hatcher <timothy at hatcher.name> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 33803: Web Inspector: PanelEnablerView._windowResized is slow, called even
when the view is hidden
https://bugs.webkit.org/show_bug.cgi?id=33803

Attachment 46906: patch (comments followed)
https://bugs.webkit.org/attachment.cgi?id=46906&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Not resizing things like column widths when the window resizes sounds like a
bug.

I still think all panels should have all their resize logic in
updateMainViewWidth, and none would impement a version of resize. Only Panel
would have resize that calls updateMainViewWidth.

THe width passed to updateMainViewWidth in that case can be the current
offsetWidth.


More information about the webkit-reviews mailing list