[webkit-reviews] review denied: [Bug 33829] Web Inspector: Timeline panel's reset button problem : [Attachment 46897] The fix for reset button at Timeline panel

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 19 02:38:59 PST 2010


Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at google.com>'s request for review:
Bug 33829: Web Inspector: Timeline panel's reset button problem
https://bugs.webkit.org/show_bug.cgi?id=33829

Attachment 46897: The fix for reset button at Timeline panel
https://bugs.webkit.org/attachment.cgi?id=46897&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +	   if (recordsInWindow.length > startIndex) 
> +	       while (startIndex > 0 &&  recordsInWindow[startIndex].parent)
> +		   startIndex--;
> +	   else 
> +	       startIndex = recordsInWindow.length ? recordsInWindow.length - 1
: 0;
> +

I think that what has been happening here was fundamentally wrong. It probably
regressed when I introduced expansion/collapsing. Row offset can no longer be
calculated as number of record * row height. We now need to take expanded state
into consideration.


More information about the webkit-reviews mailing list