[webkit-reviews] review requested: [Bug 29564] [Qt] Webkit Button Size : [Attachment 46882] Patch with test case

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 29564: [Qt] Webkit Button Size
https://bugs.webkit.org/show_bug.cgi?id=29564

Attachment 46882: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=46882&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
It is unclear to me how we benefit from using QMacStyle instead of the macro
definition Q_WS_MAC since we need to use Q_WS_MAC anyway to conditionally
#include <QMacStyle> and surround any code blocks that use QMacStyle. So, I
have removed the changes related to QMacStyle from the patch. If we do decide
to switch to using QMacStyle, I suggest we do this in a separate bug.

Moreover, I have updated the layout test and expected results so that we do not
need platform-specific results. I chose to output a custom PASS/FAIL message
when testing the fifth button in the test case instead of outputting the height
of the button (which is platform-specific) so as to avoid the need for
platform-specific results.