[webkit-reviews] review granted: [Bug 33776] Rewrite SVG <use> support in a modern-fashion : [Attachment 46870] Updated patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 18 17:47:05 PST 2010
Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 33776: Rewrite SVG <use> support in a modern-fashion
https://bugs.webkit.org/show_bug.cgi?id=33776
Attachment 46870: Updated patch v3
https://bugs.webkit.org/attachment.cgi?id=46870&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
Niko an I had a long discussen and went through the code step by step. Niko
already fixed all issues.
The zero check is neccessary here. Negative offsets are allowed. Niko will
change the alphabetic order before landing.
r=me
Great patch Niko!
More information about the webkit-reviews
mailing list