[webkit-reviews] review granted: [Bug 11031] Another crazy counters bug : [Attachment 46866] New Proposed patch. Fixed style issue that I missed in my original submission.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Carol Szabo <carol.szabo at nokia.com>'s
request for review:
Bug 11031: Another crazy counters bug
https://bugs.webkit.org/show_bug.cgi?id=11031

Attachment 46866: New Proposed patch. Fixed style issue that I missed in my
original submission.
https://bugs.webkit.org/attachment.cgi?id=46866&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -void RenderObject::styleDidChange(StyleDifference diff, const RenderStyle*)
> +void RenderObject::styleDidChange(StyleDifference diff, const
RenderStyle*oldStyle)

Missing space here.

> Index: LayoutTests/ChangeLog
> ===================================================================
> --- LayoutTests/ChangeLog	(revision 53399)
> +++ LayoutTests/ChangeLog	(working copy)
> @@ -1,3 +1,32 @@
> +2010-01-18  Carol Szabo  <carol.szabo at nokia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Another crazy counters bug
> +	   https://bugs.webkit.org/show_bug.cgi?id=11031
> +
> +	   * fast/css/counters/counter-increment-002-expected.txt: Added.
> +	   * fast/css/counters/counter-increment-002.html: Added.
> +	   * fast/css/counters/counter-reset-000-expected.txt: Added.
> +	   * fast/css/counters/counter-reset-000.html: Added.
> +	   * fast/css/counters/counter-reset-002-expected.txt: Added.
> +	   * fast/css/counters/counter-reset-002.html: Added.
> +
> +2010-01-18  Carol Szabo  <carol.szabo at nokia.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Another crazy counters bug
> +	   https://bugs.webkit.org/show_bug.cgi?id=11031
> +	   Added tests for dynamic DOM changes affecting counters.
> +
> +	   * fast/css/counters/counter-increment-002.html: Added.
> +	   * fast/css/counters/counter-reset-000.html: Added.
> +	   * fast/css/counters/counter-reset-002.html: Added.
> +	   * fast/css/counters/counter-increment-002-expected.txt: Added.
> +	   * fast/css/counters/counter-reset-000-expected.txt: Added.
> +	   * fast/css/counters/counter-reset-002-expected.txt: Added.
> +

Double change log here.

You should post another patch without the double change log.