[webkit-reviews] review requested: [Bug 33514] [Qt] Implement GraphicsLayer for accelerated layer compositing : [Attachment 46859] compositing layers for Qt: Take 3

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has asked  for review:
Bug 33514: [Qt] Implement GraphicsLayer for accelerated layer compositing
https://bugs.webkit.org/show_bug.cgi?id=33514

Attachment 46859: compositing layers for Qt: Take 3
https://bugs.webkit.org/attachment.cgi?id=46859&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
The fixes are:
- many style fixes based on the previous two reviews, GraphicsLayerQt.cpp is
hopefully much more readable now
- modified QGVLauncher to enable a more parameterized approach (caching?
viewport udpate mode?). This would allow to easily test how compositing reacts
to different QGV modes
- The scrollbar overlay item in QGraphicsWebView now only instantiates when
compositing is needed - and gets deleted when compositing is cleared. That
means that the overhead for non-composited web pages is close to none (a couple
of boolean checks)