[webkit-reviews] review granted: [Bug 33245] Second right floated image misplacment : [Attachment 46837] Create a root line box for trailing floats after the line break on the last line

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 33245: Second right floated image misplacment
https://bugs.webkit.org/show_bug.cgi?id=33245

Attachment 46837: Create a root line box for trailing floats after the line
break on the last line
https://bugs.webkit.org/attachment.cgi?id=46837&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Neither the change log nor the source files explain the role of this additional
box. I think you need a one-sentence comment stating what, to you, is obvious.

> +    TrailingFloatsRootInlineBox(RenderObject* obj) : RootInlineBox(obj)

I would call this "object", not "obj".

> +    virtual int virtualHeight() const { return 0; }

I would make this member function private. It would be a programming error to
call this with a TrailingFloatsRootInlineBox*.