[webkit-reviews] review requested: [Bug 32461] [Qt] Adding QPixmap/QImage support for the Qt hybrid layer : [Attachment 46835] Increased test coverage to Kent's request - fixed a compilation issue that slipped through...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 18 11:32:51 PST 2010


Noam Rosenthal <noam.rosenthal at nokia.com> has asked  for review:
Bug 32461: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
https://bugs.webkit.org/show_bug.cgi?id=32461

Attachment 46835: Increased test coverage to Kent's request - fixed a
compilation issue that slipped through...
https://bugs.webkit.org/attachment.cgi?id=46835&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
This should be a pretty straightforward review, as it changes very little from
the last patch (which apparently had a compilation issue that I ovelooked). It
mainly adds more tests like having a signal with image/pixmap, testing toString
for the intermediate object, and sending garbage to a slot that wants an
image/pixmap.


More information about the webkit-reviews mailing list