[webkit-reviews] review denied: [Bug 33783] [DRT][Mac] Add modifiers parameter to mouseDown() and mouseUp() : [Attachment 46790] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 33783: [DRT][Mac] Add modifiers parameter to mouseDown() and mouseUp()
https://bugs.webkit.org/show_bug.cgi?id=33783

Attachment 46790: Patch
https://bugs.webkit.org/attachment.cgi?id=46790&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    [self performSelector:@selector(mouseDown:) withObject:nil
afterDelay:0];
> -    [self performSelector:@selector(mouseUp:) withObject:nil afterDelay:0];
> +    [self performSelector:@selector(mouseDown:withModifiers:) withObject:nil
afterDelay:0];
> +    [self performSelector:@selector(mouseUp:withModifiers:) withObject:nil
afterDelay:0];

This isn't reliable. The argument to "withModifiers" will be random data on the
stack. The object "nil" is passed as the first argument, but no second argument
is passed. The simplest way I can think of to make this work is to keep a
method with the old name and have it call the new method. There may be other
alternatives.

review- because of this