[webkit-reviews] review granted: [Bug 33791] check-webkit-style: Checking patch does not work when script not run from source root : [Attachment 46809] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 18 10:12:12 PST 2010
Adam Barth <abarth at webkit.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 33791: check-webkit-style: Checking patch does not work when script not run
from source root
https://bugs.webkit.org/show_bug.cgi?id=33791
Attachment 46809: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=46809&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks good, especially because the style module has so few dependencies on
the rest of webkitpy. We'll have to see how this approach scales to other
modules.
Why is style_references outside the style module? I would have expected it to
be located at style.references.
More information about the webkit-reviews
mailing list