[webkit-reviews] review denied: [Bug 33794] Web Inspector: Speed-up Timeline panel scrolling (second iteration). : [Attachment 46814] The fixes for Timeline panel scrolling speed

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at google.com>'s request for review:
Bug 33794: Web Inspector: Speed-up Timeline panel scrolling (second iteration).
https://bugs.webkit.org/show_bug.cgi?id=33794

Attachment 46814: The fixes for Timeline panel scrolling speed
https://bugs.webkit.org/attachment.cgi?id=46814&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    this._graphRows = document.createElement("div");

We typically call elements someElement. Maybe kill it?

> -	   var start = (record.startTime - this.minimumBoundary) /
this.boundarySpan * 100;
> -	   var end = (record.endTime - this.minimumBoundary) /
this.boundarySpan * 100;
> +	   var start = (record.startTime - this._context.minB) /
this._context.bSpan * 100;

this._context.minimumBoundary. Btw, this calculator is supposed to cache min
and max boundaries, so it is not clear why you are gaining some win out of it.
Maybe cache is broken? Or typeof ... === "number" works slowly? Should we try
using -1 as an uninitialized value then?