[webkit-reviews] review requested: [Bug 32054] Asynchronous Icon loading support : [Attachment 46796] Proposed patch (rev.5)

[bugzilla-daemon at webkit.org]

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 32054: Asynchronous Icon loading support
https://bugs.webkit.org/show_bug.cgi?id=32054

Attachment 46796: Proposed patch (rev.5)
https://bugs.webkit.org/attachment.cgi?id=46796&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
The code logic is not changed from rev.4.  ChangeLog and comments are updated.
 - ChangeLog:  Mention that we'll remove the existing
Icon::createIconForFiles().
 - Updated comments in empty ChromeClient::iconForFiles() implementations
   "No need to implement this." -> "FIXME: We should move the code from
Icon::createIconForFiles()."
 - Add notImplemented() to ChromeClient::iconForFiles().