[webkit-reviews] review requested: [Bug 30883] [Gtk] Implement AtkText for HTML elements which contain text : [Attachment 46791] Handle the issue from comment #28, add sanity checks to objectAndOffsetUnignored, new tests, style compliance changes....

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 30883: [Gtk] Implement AtkText for HTML elements which contain text
https://bugs.webkit.org/show_bug.cgi?id=30883

Attachment 46791: Handle the issue from comment #28, add sanity checks to
objectAndOffsetUnignored, new tests, style compliance changes....
https://bugs.webkit.org/attachment.cgi?id=46791&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
This patch makes the following changes:

1. Moves the text collapsing/assembling functionality that was in
getPangoLayoutForAtk to the newly-created textForObject.

2. webkit_accessible_text_get_text now falls back on textForObject when it
comes up empty.

3. Adds a check in textForObject so that we don't double-add newlines when we
have a BR.

4. Adds new tests for items 2 and 3 above to testatk.c

5. (Hopefully) brings the rest of testatk.c into compliance with the style
guidelines. Also there were several instances of our calling
atk_object_ref_accessible_child(), but never unref'ing the object at the end of
the test. I assume we should be unref'ing them.

6. Adds some sanity checks to objectAndOffsetUnignored which (hopefully)
address Xan's concerns.