[webkit-reviews] review requested: [Bug 33775] check-webkit-style: File reading code should be shared between cpp_style.py and text_style.py. : [Attachment 46785] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 17 21:03:15 PST 2010


Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 33775: check-webkit-style: File reading code should be shared between
cpp_style.py and text_style.py.
https://bugs.webkit.org/show_bug.cgi?id=33775

Attachment 46785: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=46785&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
In addition, I adjusted the logic slightly so that no error gets logged when an
exempted file is encountered, per this comment:

https://bugs.webkit.org/show_bug.cgi?id=33771#c6

If you'd like, I can change it back.


More information about the webkit-reviews mailing list