[webkit-reviews] review canceled: [Bug 32461] [Qt] Adding QPixmap/QImage support for the Qt hybrid layer : [Attachment 46751] Fixed style issues reported by Simon

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 17 13:59:05 PST 2010


Noam Rosenthal <noam.rosenthal at nokia.com> has canceled Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 32461: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
https://bugs.webkit.org/show_bug.cgi?id=32461

Attachment 46751: Fixed style issues reported by Simon
https://bugs.webkit.org/attachment.cgi?id=46751&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
Note that some of the c-style castings are a style-copy from qt_runtime.cpp,
mainly where enums are involved.
However, I changed all of them to c++ style, except for the ones that can only
be done c-style, such as (UChar*).

Hope this is stylish enough, sorry to waste your time this coding-style stuff -
I come from a more hack-and-run background but it's getting better :)
N


More information about the webkit-reviews mailing list