[webkit-reviews] review requested: [Bug 32900] [GTK] Crashes cleaning clipboard contents, with page cache enabled : [Attachment 46753] Fix crash by passing WebView object to the clipboard functions instead of Page

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 32900: [GTK] Crashes cleaning clipboard contents, with page cache enabled
https://bugs.webkit.org/show_bug.cgi?id=32900

Attachment 46753: Fix crash by passing WebView object to the clipboard
functions instead of Page
https://bugs.webkit.org/attachment.cgi?id=46753&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
This is the same patch I posted to 33746 (which I marked as duplicate to this
one) with a couple changes:

1. adopting the recommendation of mrobinson about checking if data is NULL,
because in the near future it might be (for non-X11 primary clipboards)
2. check the return of set_with_data, and unref the webView if the call failed,
to avoid leaking

Martin also raised the issue of the webView being unrefed in the get function -
my original patch did that as well, and I couldn't see how it would be called
twice, or in addition to clear yet (by looking at the GTK+ code), but I may be
wrong.