[webkit-reviews] review requested: [Bug 33514] [Qt] Implement GraphicsLayer for accelerated layer compositing : [Attachment 46752] compositing layers for Qt

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has asked  for review:
Bug 33514: [Qt] Implement GraphicsLayer for accelerated layer compositing
https://bugs.webkit.org/show_bug.cgi?id=33514

Attachment 46752: compositing layers for Qt 
https://bugs.webkit.org/attachment.cgi?id=46752&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
Since there's no way I can think of to chop this feature into small commits,
I'm posting it now as one patch. 

Composite layers for CSS animations seem to be pretty solid. Some further
testing needs to be done, but so far all the LayoutTests work, and I don't
foresee any big architectural changes apart from inevitable bug-fixes.

Currently the compositing-layers feature only works in QGraphicsWebView, and
only if QWebSettings::AcceleratedCompositingEnabled is true.

I tried to get all the style issues done in advance but of course I might have
overlooked a few things. Hopefully reviewing this won't be a hassle :)
In my view this could maybe go in and marked as an "experimental" feature and
we can make it more solid as we go along - since there's no new API and it's an
optional feature with QWebSettings, the risk is low. The main changes that can
affect other parts are in qgraphicswebview.cpp, and those should probably be
reviewed more carefully.