[webkit-reviews] review granted: [Bug 32279] composited layers are sometimes clipped : [Attachment 46720] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 16 11:08:09 PST 2010


Darin Adler <darin at apple.com> has granted Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 32279: composited layers are sometimes clipped
https://bugs.webkit.org/show_bug.cgi?id=32279

Attachment 46720: Patch
https://bugs.webkit.org/attachment.cgi?id=46720&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    //m_rootLayer->setAnchorPoint(CGPointMake(0, 1));
> +    //CGPoint pos = m_rootLayer->position();

You should remove this commented-out code. Unless it's needed.

While I'm not as familiar with this code as some, and there's no regression
testing here, the patch looks fine otherwise. Please remove the commented-out
code.

And if you think someone else (Simon) should review this, feel free to change
back from review+ to review?.


More information about the webkit-reviews mailing list