[webkit-reviews] review requested: [Bug 33475] Create a unit-tested subroutine to parse a patch created by svn-create-patch : [Attachment 46744] Proposed patch

[bugzilla-daemon at webkit.org]

Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 33475: Create a unit-tested subroutine to parse a patch created by
svn-create-patch
https://bugs.webkit.org/show_bug.cgi?id=33475

Attachment 46744: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=46744&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Note that there is about 50 lines of near cut-and-paste between the two helper
subroutines at the bottom of the two unit test files parseDiffHeader.pl and
parseDiff.pl.  While it would be possible to share some of this code, I view it
more as a (temporary) coincidence that they can be so similar.	If the
signature, return value, or test logic for either parseDiff() or
parseDiffHeader() were to change slightly, then for readability reasons it
would probably not be worthwhile to share the two helper functions.  I am open
to breaking some of that into a separate file though if you feel it's
important.  Thanks in advance for reviewing!