[webkit-reviews] review granted: [Bug 33751] Frame::matchLabelsAgainstElement should take id attribute into account (as well as name) : [Attachment 46728] Revised patch that fixes the doubled semicolon.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 16 10:42:08 PST 2010
Darin Adler <darin at apple.com> has granted John Sullivan <sullivan at apple.com>'s
request for review:
Bug 33751: Frame::matchLabelsAgainstElement should take id attribute into
account (as well as name)
https://bugs.webkit.org/show_bug.cgi?id=33751
Attachment 46728: Revised patch that fixes the doubled semicolon.
https://bugs.webkit.org/attachment.cgi?id=46728&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
I'm not so fond with the name "mutable" in the local variable names here. It's
also too bad we have no way to write regression tests for this function.
r=me despite that tho
More information about the webkit-reviews
mailing list