[webkit-reviews] review denied: [Bug 33752] Assertion failure when getting a href attribute with prefix : [Attachment 46727] proposed fix

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 33752: Assertion failure when getting a href attribute with prefix
https://bugs.webkit.org/show_bug.cgi?id=33752

Attachment 46727: proposed fix
https://bugs.webkit.org/attachment.cgi?id=46727&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Normally if you are comparing an atomic string to a string constant, we use an
atomic string constant to make the check less expensive.

I suggest we add the strings "xmlns", "http://www.w3.org/2000/xmlns/", and
"xml" all to XMLNames.h alongside xmlNamespaceURI and use named constants
instead of literal strings.

I'm going to say review+ but I am close to a review- because I'd like us to use
atomic strings when comparing with other atomic strings.